RESOLVED FIXED Bug 59978
add image toggling behavior from old-run-webkit-tests 
https://bugs.webkit.org/show_bug.cgi?id=59978
Summary add image toggling behavior from old-run-webkit-tests
Ojan Vafai
Reported 2011-05-02 16:56:03 PDT
add image toggling behavior from old-run-webkit-tests
Attachments
Patch (20.02 KB, patch)
2011-05-02 16:59 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-05-02 16:59:55 PDT
Created attachment 92006 [details] Patch
Tony Chang
Comment 2 2011-05-02 17:32:08 PDT
Comment on attachment 92006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92006&action=review > LayoutTests/fast/harness/resources/results-test.js:114 > +{ Nit: trailing whitespace > Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:251 > +""" % (self._testname, self.output_filename('-diff.png'), self.output_filename('')) > + self._port._filesystem.write_binary_file(diffs_html_filename, html) Nit: When I have lots of replacement params, I normally switch to the named placeholders.
Ojan Vafai
Comment 3 2011-05-03 09:30:52 PDT
Committed r85610: <http://trac.webkit.org/changeset/85610>
Note You need to log in before you can comment on or make changes to this bug.