WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59963
fix failing printing_unittest on win32
https://bugs.webkit.org/show_bug.cgi?id=59963
Summary
fix failing printing_unittest on win32
Dirk Pranke
Reported
2011-05-02 14:34:15 PDT
fix failing printing_unittest on win32
Attachments
Patch
(1.69 KB, patch)
2011-05-02 14:34 PDT
,
Dirk Pranke
abarth
: review+
abarth
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-05-02 14:34:57 PDT
Created
attachment 91982
[details]
Patch
Adam Barth
Comment 2
2011-05-02 18:11:40 PDT
Comment on
attachment 91982
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=91982&action=review
> Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:588 > - # FIXME: scm.py outputs debug logging to stderr. It should probably go to stdout. > - self.assertFalse(err.empty()) > + # FIXME: debug output from the port and scm objects may or may not go > + # to stderr, so there's no point in testing its contents here. > + # self.assertTrue(err.empty())
Generally we don't want commented out code. Maybe just remove it?
Dirk Pranke
Comment 3
2011-05-02 18:17:04 PDT
Sure, I can do that.
Dirk Pranke
Comment 4
2011-05-03 14:14:57 PDT
Committed
r85658
: <
http://trac.webkit.org/changeset/85658
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug