Bug 59963 - fix failing printing_unittest on win32
Summary: fix failing printing_unittest on win32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 14:34 PDT by Dirk Pranke
Modified: 2011-05-03 14:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2011-05-02 14:34 PDT, Dirk Pranke 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-05-02 14:34:15 PDT 
fix failing printing_unittest on win32
Comment 1 Dirk Pranke 2011-05-02 14:34:57 PDT 
Created attachment 91982 [details]
Patch
Comment 2 Adam Barth 2011-05-02 18:11:40 PDT 
Comment on attachment 91982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91982&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:588
> -        # FIXME: scm.py outputs debug logging to stderr. It should probably go to stdout.
> -        self.assertFalse(err.empty())
> +        # FIXME: debug output from the port and scm objects may or may not go
> +        # to stderr, so there's no point in testing its contents here.
> +        # self.assertTrue(err.empty())

Generally we don't want commented out code.  Maybe just remove it?
Comment 3 Dirk Pranke 2011-05-02 18:17:04 PDT 
Sure, I can do that.
Comment 4 Dirk Pranke 2011-05-03 14:14:57 PDT 
Committed r85658: <http://trac.webkit.org/changeset/85658>