Bug 59959 - Handle DispatchOnConnectionQueue for asynchronous messages
Summary: Handle DispatchOnConnectionQueue for asynchronous messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 13:51 PDT by Anders Carlsson
Modified: 2011-05-02 14:05 PDT (History)
0 users

See Also:

Attachments
Patch (7.80 KB, patch)
2011-05-02 13:54 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (8.11 KB, patch)
2011-05-02 14:04 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-05-02 13:51:23 PDT 
Handle DispatchOnConnectionQueue for asynchronous messages
Comment 1 Anders Carlsson 2011-05-02 13:54:35 PDT 
Created attachment 91975 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-05-02 13:58:49 PDT 
Comment on attachment 91975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91975&action=review

> Source/WebKit2/ChangeLog:11
> +        * Scripts/webkit2/messages.py:

Some function-level comments here would be nice.

> Source/WebKit2/Scripts/webkit2/messages.py:84
> -            match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line)
> +            match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\))?(?:\s+(.*))?', line)

Please explain this change in the ChangeLog.

> Source/WebKit2/Scripts/webkit2/messages.py:578
> +    sync_dispatch_on_connection_queue_messages = []

Why don't we do anything with this list? I think this is why the GetPlugins and TestMultipleAttributes messages disappeared from the expected output.
Comment 3 Anders Carlsson 2011-05-02 14:03:44 PDT 
(In reply to comment #2)
> (From update of attachment 91975 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91975&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        * Scripts/webkit2/messages.py:
> 
> Some function-level comments here would be nice.

Done.

> 
> > Source/WebKit2/Scripts/webkit2/messages.py:84
> > -            match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?', line)
> > +            match = re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\))?(?:\s+(.*))?', line)
> 
> Please explain this change in the ChangeLog.

Done.

> 
> > Source/WebKit2/Scripts/webkit2/messages.py:578
> > +    sync_dispatch_on_connection_queue_messages = []
> 
> Why don't we do anything with this list? I think this is why the GetPlugins and TestMultipleAttributes messages disappeared from the expected output.

Yup. We don't handle synchronous messages with the DispatchOnConnectionQueue attribute. I'm not sure if we actually need that.
Comment 4 Anders Carlsson 2011-05-02 14:04:05 PDT 
Created attachment 91978 [details]
Patch
Comment 5 Anders Carlsson 2011-05-02 14:05:02 PDT 
Committed r85519: <http://trac.webkit.org/changeset/85519>