Bug 59957 - Prune #includes from FrameView.h (Part 1)
Summary: Prune #includes from FrameView.h (Part 1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 13:30 PDT by Sam Weinig
Modified: 2011-05-11 14:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2011-05-02 13:31 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2011-05-02 14:03 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (3.90 KB, patch)
2011-05-02 14:19 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-05-02 13:30:14 PDT
Prune #includes from FrameView.h (Part 1)
Comment 1 Sam Weinig 2011-05-02 13:31:07 PDT
Created attachment 91968 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-02 13:44:03 PDT
Attachment 91968 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8526825
Comment 3 Sam Weinig 2011-05-02 14:03:31 PDT
Created attachment 91977 [details]
Patch
Comment 4 WebKit Review Bot 2011-05-02 14:06:29 PDT
Attachment 91977 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/Scrollbar.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2011-05-02 14:11:14 PDT
Attachment 91977 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8529793
Comment 6 Sam Weinig 2011-05-02 14:19:14 PDT
Created attachment 91979 [details]
Patch
Comment 7 WebKit Review Bot 2011-05-02 14:20:21 PDT
Attachment 91979 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/Scrollbar.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Review Bot 2011-05-02 15:25:09 PDT
Attachment 91979 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8526853
Comment 9 WebKit Review Bot 2011-05-02 15:57:39 PDT
Attachment 91979 [details] did not pass chromium-ews:
Output: http://queues.webkit.org/results/8534172
Comment 10 Build Bot 2011-05-02 22:18:18 PDT
Attachment 91979 [details] did not build on win:
Build output: http://queues.webkit.org/results/8530871
Comment 11 Sam Weinig 2011-05-03 10:13:30 PDT
Landed in r85615.