Bug 59954 - Need a way to handle CoreIPC messages on the connection work queue
: Need a way to handle CoreIPC messages on the connection work queue
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-05-02 12:27 PST by
Modified: 2011-05-02 12:41 PST (History)


Attachments
Patch (4.18 KB, patch)
2011-05-02 12:29 PST, Anders Carlsson
aroben: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-02 12:27:15 PST
Need a way to handle CoreIPC messages on the connection work queue
------- Comment #1 From 2011-05-02 12:29:41 PST -------
Created an attachment (id=91957) [details]
Patch
------- Comment #2 From 2011-05-02 12:34:27 PST -------
(From update of attachment 91957 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=91957&action=review

> Source/WebKit2/ChangeLog:10
> +        member function, willProcessMessageOnClientRunLoop which should return true if the message
> +        was processed and false otherwise. Users of Connection can use addQueueClient to add clients

I'd say "should return true if the message should be forwarded to the Connection::Client's run loop for processing and false otherwise". (Note that this reverses the meaning of the return value.) That seems slightly closer in spirit to Cocoa delegate methods that start with "will".

> Source/WebKit2/Platform/CoreIPC/Connection.cpp:242
> +void Connection::addQueueClient(QueueClient* queueClient)
> +{
> +    MutexLocker locker(m_connectionQueueClientsMutex);
> +    m_connectionQueueClients.append(queueClient);
> +}

Should we assert that the client isn't already in m_connectionQueueClients?

> Source/WebKit2/Platform/CoreIPC/Connection.h:108
> +    protected:
> +        virtual ~QueueClient() { }
> +
> +    public:
> +        virtual bool willProcessMessageOnClientRunLoop(Connection*, MessageID, ArgumentDecoder*) = 0;

Maybe reverse these sections?
------- Comment #3 From 2011-05-02 12:41:32 PST -------
Committed r85503: <http://trac.webkit.org/changeset/85503>