Bug 59950 - Clean up AssemblerBuffer to use a Vector internally.
Summary: Clean up AssemblerBuffer to use a Vector internally.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 11:21 PDT by Gavin Barraclough
Modified: 2013-04-30 04:39 PDT (History)
1 user (show)

See Also:


Attachments
The patch (12.45 KB, patch)
2011-05-02 11:23 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-05-02 11:21:15 PDT
AssemblerBuffer handles reallocing a byte array itself - stop that.
Comment 1 Gavin Barraclough 2011-05-02 11:23:02 PDT
Created attachment 91944 [details]
The patch
Comment 2 Gavin Barraclough 2011-05-02 16:02:27 PDT
fixed in r 85497
Comment 3 石梦军 2013-04-30 04:39:30 PDT
this only replace the realloc with the vector, but in the flushConstantPool function of AssemblerBufferWithConstantPool.h file, it use the char *  to replace the void*, is it any difference?