RESOLVED FIXED 59939
Web Inspector: revision history storage is too slow. 
https://bugs.webkit.org/show_bug.cgi?id=59939
Summary Web Inspector: revision history storage is too slow.
Pavel Feldman
Reported 2011-05-02 09:29:53 PDT
It turns out that iterating localStorage keys is very expensive (results in slow inspector start), refactor revision history in order not to rely upon that operation.
Attachments
Patch (7.72 KB, patch)
2011-05-02 09:34 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-05-02 09:34:29 PDT
Created attachment 91929 [details] Patch
Yury Semikhatsky
Comment 2 2011-05-03 01:25:37 PDT
Comment on attachment 91929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91929&action=review > Source/WebCore/inspector/front-end/Resource.js:140 > + if (resource && historyItem.loaderId === resource.loaderId) { Can we make sure there is no collision between loaderIds? > Source/WebCore/inspector/front-end/ResourceTreeModel.js:71 > WebInspector.mainResource = this._addFramesRecursively(mainFramePayload); Let's remove this: if (error) 6868 return;
Pavel Feldman
Comment 3 2011-05-03 01:52:16 PDT
(In reply to comment #2) > (From update of attachment 91929 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91929&action=review > > > Source/WebCore/inspector/front-end/Resource.js:140 > > + if (resource && historyItem.loaderId === resource.loaderId) { > > Can we make sure there is no collision between loaderIds? > We don't have unique session id yet. > > Source/WebCore/inspector/front-end/ResourceTreeModel.js:71 > > WebInspector.mainResource = this._addFramesRecursively(mainFramePayload); > > Let's remove this: > if (error) > 6868 return; I'll put console.error here.
Pavel Feldman
Comment 4 2011-05-03 02:01:53 PDT
Committed r85591: <http://trac.webkit.org/changeset/85591>
Note You need to log in before you can comment on or make changes to this bug.