Bug 59933 - Port Mozilla's IndexedDB tests: cursor mutation in object store
Summary: Port Mozilla's IndexedDB tests: cursor mutation in object store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 06:36 PDT by Mark Pilgrim (Google)
Modified: 2011-05-02 18:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.66 KB, patch)
2011-05-02 06:39 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (11.47 KB, patch)
2011-05-02 13:51 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-05-02 06:36:40 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_cursor_mutation.html?raw=1

This is a test case *adapted* from a test in Mozilla's IndexedDB test suite. The original test checked cursor mutation while iterating an index cursor (tracked as bug 59822). This test checks whether the cursor mutation is successfully recognized while iterating a straight objectstore cursor. Specifically, it deletes a record that's already been iterated, then adds a record to the objectstore during iteration, then checks that no records were skipped and that the added record is eventually found during iteration.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-05-02 06:39:43 PDT
Created attachment 91921 [details]
Patch
Comment 2 Tony Chang 2011-05-02 12:16:51 PDT
Comment on attachment 91921 [details]
Patch

Can you include the adaptations mentioned in comment 0 in the ChangeLog or in the test desctipion()?
Comment 3 Mark Pilgrim (Google) 2011-05-02 13:51:27 PDT
Created attachment 91974 [details]
Patch
Comment 4 Mark Pilgrim (Google) 2011-05-02 13:52:29 PDT
Updated test description and ChangeLog.
Comment 5 WebKit Commit Bot 2011-05-02 16:51:17 PDT
Comment on attachment 91974 [details]
Patch

Clearing flags on attachment: 91974

Committed r85553: <http://trac.webkit.org/changeset/85553>
Comment 6 WebKit Commit Bot 2011-05-02 16:51:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2011-05-02 18:58:54 PDT
The commit-queue encountered the following flaky tests while processing attachment 91974 [details]:

http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.