Bug 59914 - WebKit2: Crash closing tab with docked Web Inspector
Summary: WebKit2: Crash closing tab with docked Web Inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-05-01 22:01 PDT by Brian Weinstein
Modified: 2011-05-02 07:10 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] fix (4.85 KB, patch)
2011-05-01 22:09 PDT, Brian Weinstein 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2011-05-01 22:01:25 PDT 
There is a crash closing a tab with a docked web inspector. State isn't being torn down correctly, and the WindowMessageBroadcaster listener isn't being removed.

<rdar://problem/9359672>
Comment 1 Brian Weinstein 2011-05-01 22:09:25 PDT 
Created attachment 91881 [details]
[PATCH] fix
Comment 2 mitz 2011-05-01 22:14:13 PDT 
Comment on attachment 91881 [details]
[PATCH] fix

View in context: https://bugs.webkit.org/attachment.cgi?id=91881&action=review

> Source/WebKit2/ChangeLog:10
> +        didn't do the tear that is needed, but is called when we close the web inspector explcitly.

typo: “tear that”
Comment 3 Brian Weinstein 2011-05-01 22:44:45 PDT 
Landed in r85457.
Comment 4 Adam Roben (:aroben) 2011-05-02 07:10:04 PDT 
Can you make a test for this using TestWebKitAPI?