Bug 59907 - Prune some #includes from DOMWindow.h
Summary: Prune some #includes from DOMWindow.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 18:15 PDT by Sam Weinig
Modified: 2011-05-02 10:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.67 KB, patch)
2011-05-01 18:21 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (13.56 KB, patch)
2011-05-01 22:08 PDT, Sam Weinig 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-05-01 18:15:39 PDT 
Prune some #includes from DOMWindow.h
Comment 1 Sam Weinig 2011-05-01 18:21:41 PDT 
Created attachment 91867 [details]
Patch
Comment 2 Adam Barth 2011-05-01 18:23:43 PDT 
Comment on attachment 91867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91867&action=review

> Source/WebCore/page/DOMWindow.h:98
> -        void setSecurityOrigin(SecurityOrigin* securityOrigin) { m_securityOrigin = securityOrigin; }
> +        void setSecurityOrigin(SecurityOrigin*);

You promised to remove this function a lot time ago!
Comment 3 Sam Weinig 2011-05-01 18:25:03 PDT 
> You promised to remove this function a lot time ago!

If only you could feel my guilt.
Comment 4 WebKit Review Bot 2011-05-01 18:28:48 PDT 
Attachment 91867 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8525755
Comment 5 Early Warning System Bot 2011-05-01 18:35:30 PDT 
Attachment 91867 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8531500
Comment 6 WebKit Review Bot 2011-05-01 20:18:58 PDT 
Attachment 91867 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8526596
Comment 7 Sam Weinig 2011-05-01 22:08:35 PDT 
Created attachment 91880 [details]
Patch
Comment 8 Adam Barth 2011-05-01 22:12:11 PDT 
Comment on attachment 91880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91880&action=review

I support this product and/or service.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

OOPS!
Comment 9 Sam Weinig 2011-05-02 10:35:17 PDT 
Committed r85484: <http://trac.webkit.org/changeset/85484>