Bug 59903 - Use AssemblerLabel throughout Assembler classes, AssemblerBuffer
Summary: Use AssemblerLabel throughout Assembler classes, AssemblerBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 17:47 PDT by Gavin Barraclough
Modified: 2011-05-05 03:41 PDT (History)
1 user (show)

See Also:

Attachments
The patch (13.92 KB, patch)
2011-05-01 17:49 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-05-01 17:47:32 PDT 
Creating a lable() into the AssemblerBuffer should return an AssemblerLabel, not an unsigned int.
Comment 1 Gavin Barraclough 2011-05-01 17:49:27 PDT 
Created attachment 91861 [details]
The patch
Comment 2 Gavin Barraclough 2011-05-01 18:04:29 PDT 
Fixed in r85448
Comment 3 thouraya 2011-05-05 03:41:22 PDT 
Hello,

Due to the changes you did, building webkit for SH4 platform, I had the following error : error: AssemblerLabel does not name a type

I created a bug that fixes the issue: https://bugs.webkit.org/show_bug.cgi?id=59927


I think there is the same issue in MIPS platforms.

Regards,
Thouraya.