Bug 59886 - REGRESSIONS (r71934, r74787): In standalone media documents, (double-)clicking the media element doesn’t play/pause, clicking outside it does
Summary: REGRESSIONS (r71934, r74787): In standalone media documents, (double-)clickin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Abhishek Arya
URL: http://movies.apple.com/movies/us/app...
Keywords: InRadar, Regression
Depends on: 59976
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-01 13:28 PDT by mitz
Modified: 2011-05-02 16:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.49 KB, patch)
2011-05-01 16:36 PDT, Abhishek Arya
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-05-01 13:28:50 PDT
<rdar://problem/9319469>

In a standalone media document, such as the URL, clicking the video element should pause it and double-clicking it should resume playback. Clicking and double-clicking in the background should have no effect.

r71934 broke the clicking/double-clicking the video behavior.

r74787 made it so clicking/double-clicking the background pauses/plays the video.

Both are wrong.
Comment 1 mitz 2011-05-01 13:33:21 PDT
The mistake in r74787 is obvious (not checking the target element).
Comment 2 Abhishek Arya 2011-05-01 15:59:40 PDT
Sorry about the regression. I accidently assumed the descendant node check on mouse click, double click events(code cleanup) while fixing a sec bug on key down event which does do the descendants check on target node. uploading a fix soon.
Comment 3 Abhishek Arya 2011-05-01 16:36:28 PDT
Created attachment 91859 [details]
Patch
Comment 4 Abhishek Arya 2011-05-01 22:59:56 PDT
Committed r85458: <http://trac.webkit.org/changeset/85458>
Comment 5 Abhishek Arya 2011-05-01 23:01:05 PDT
Thank you Eric. Filed https://bugs.webkit.org/show_bug.cgi?id=59917 to cover regression from r71934.