RESOLVED FIXED 59885
Web Inspector: combine status bar button glyphs. 
https://bugs.webkit.org/show_bug.cgi?id=59885
Summary Web Inspector: combine status bar button glyphs.
Pavel Feldman
Reported 2011-05-01 13:06:52 PDT
Patch to follow.
Attachments
Patch (45.30 KB, patch)
2011-05-01 13:08 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (45.30 KB, patch)
2011-05-01 13:28 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (45.30 KB, patch)
2011-05-02 05:36 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-05-01 13:08:53 PDT
Created attachment 91836 [details] Patch
Early Warning System Bot
Comment 2 2011-05-01 13:18:54 PDT
Attachment 91836 [details] did not build on qt: Build output: http://queues.webkit.org/results/8523818
WebKit Review Bot
Comment 3 2011-05-01 13:19:35 PDT
Attachment 91836 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8530419
Pavel Feldman
Comment 4 2011-05-01 13:28:20 PDT
Created attachment 91837 [details] Patch
Joseph Pecoraro
Comment 5 2011-05-01 13:32:51 PDT
Cool, I've always thought this would be a good idea. It makes adding a new image slightly more difficult, but it has a number of nice improvements (reducing separate requests [great for remote], all images show at once, smaller total size). Any reason why you stopped at 10 per line? Now there is a line with 9 "blanks" and causes the file size to be larger than it needs to be.
Early Warning System Bot
Comment 6 2011-05-01 13:41:11 PDT
Attachment 91837 [details] did not build on qt: Build output: http://queues.webkit.org/results/8521979
WebKit Review Bot
Comment 7 2011-05-01 13:44:54 PDT
Attachment 91837 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8521984
Pavel Feldman
Comment 8 2011-05-02 05:36:07 PDT
Created attachment 91913 [details] Patch
Pavel Feldman
Comment 9 2011-05-02 05:38:34 PDT
(In reply to comment #5) > Cool, I've always thought this would be a good idea. It makes adding a > new image slightly more difficult, but it has a number of nice > improvements (reducing separate requests [great for remote], all images > show at once, smaller total size). > This is great not only for remote. > Any reason why you stopped at 10 per line? Now there is a line with > 9 "blanks" and causes the file size to be larger than it needs to be. Yeah, it is easier to reference the image that way (using row and column with 10 items per row). I don't think we care about few extra bytes for that.
Pavel Feldman
Comment 10 2011-05-03 00:52:52 PDT
Comment on attachment 91913 [details] Patch Clearing flags on attachment: 91913 Committed r85587: <http://trac.webkit.org/changeset/85587>
Pavel Feldman
Comment 11 2011-05-03 00:53:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.