Bug 59882 - webkit-patch fails when not run from root
Summary: webkit-patch fails when not run from root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 11:51 PDT by Adam Barth
Modified: 2011-05-01 12:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2011-05-01 11:52 PDT, Adam Barth 		eric: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-01 11:51:18 PDT 
webkit-patch fails when not run from root
Comment 1 Adam Barth 2011-05-01 11:52:18 PDT 
Created attachment 91830 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-01 11:54:18 PDT 
Comment on attachment 91830 [details]
Patch

I'm confused.  I thought that SVN didn't run all commands relative to the root to support maciej's fancy -d thing.
Comment 3 Adam Barth 2011-05-01 11:55:47 PDT 
scm.py always interprets file paths relative to the root of the working copy.  The -d option restricts the scope of our "stat" commands to restrict which parts of the working copy we operate upon.
Comment 4 Adam Barth 2011-05-01 11:58:13 PDT 
Committed r85424: <http://trac.webkit.org/changeset/85424>
Comment 5 Eric Seidel (no email) 2011-05-01 12:00:57 PDT 
Letting other python hackers see this go by, to hopefully end any confusion here.