NEW 59880
test-webkitpy fails if users have Google App Engine installed, but no PIL 
https://bugs.webkit.org/show_bug.cgi?id=59880
Summary test-webkitpy fails if users have Google App Engine installed, but no PIL
Eric Seidel (no email)
Reported 2011-05-01 11:23:26 PDT
test-webkitpy fails if users have Google App Engine installed, but no PIL This is a bug in GAE's "testbed" module: https://code.google.com/p/googleappengine/issues/detail?id=4818 We could detect that testbed failed to import in activeworkitems_unittest, but I'm not sure how we abort processing of the rest of the file. Adam hit this bug, but I suspect most contributors do not have GAE installed (and dont' run test-webkitpy).
Attachments
Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-05-02 13:33:18 PDT
I think I've also hit this.
Eric Seidel (no email)
Comment 2 2011-05-02 14:58:38 PDT
If you have suggestions as to how to best skip all the ActiveWorkItemsTest class in that case, I'm all ears! We could have a global variable about PIL availability in activeworkitems_unittest.py and then have every method in the class check it? Or we could somehow re-define the ActiveWorkItemsTest class at the end of the file if PIL is unfound?
Dirk Pranke
Comment 3 2011-05-02 15:50:16 PDT
I'm not sure. Maybe the thing to do is to fix GAE? As you say, there's only a couple of us that will run into this in the meantime.
Mihai Parparita
Comment 4 2011-05-02 18:27:38 PDT
As far as I can tell, this has been fixed (http://s/20374838 for those on the Google corporate network) on the GAE side, presumably it will be in the next SDK release.
Eric Seidel (no email)
Comment 5 2011-05-10 11:41:41 PDT
GAE 1.5.0 came out today. It may have this fix in it.
Note You need to log in before you can comment on or make changes to this bug.