Bug 59856 - Plug-in failed to initialize message should be called when Java fails to initialize
Summary: Plug-in failed to initialize message should be called when Java fails to init...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 18:06 PDT by Steve Falkenburg
Modified: 2011-05-02 11:05 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2011-04-29 18:16 PDT, Steve Falkenburg 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-04-29 18:06:31 PDT 
Plug-in failed to initialize message should be called when Java fails to initialize
Comment 1 Steve Falkenburg 2011-04-29 18:16:50 PDT 
Created attachment 91784 [details]
Patch
Comment 2 Maciej Stachowiak 2011-04-30 03:05:42 PDT 
Comment on attachment 91784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91784&action=review

r=me

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1257
> +    const String mimeType = "application/x-java-applet";

I suggest naming this javaMimeType or appletMimeType or something like that.
Comment 3 Sam Weinig 2011-04-30 17:19:33 PDT 
I don't understand this patch.  This is not checking initialization, but rather whether a java plugin exists or not.
Comment 4 Steve Falkenburg 2011-04-30 19:15:23 PDT 
Inside WebPage::createPlugin for the failure case, GetPluginPath succeeds, returning the proper path to the Java plug-in.

The failure occurs when NetscapePluginModule::getOrCreate calls pluginModule->load() to initialize the plug-in. When this fails, getOrCreate returns 0, and then createPlugin returns 0.

The Java applet path doesn't appear to use PluginView, so the call you added to DidFailToInitializePlugin in PluginView::initializePlugin doesn't get called in this case.

I'd be open to fixing this another way - let me know.
Comment 5 Steve Falkenburg 2011-05-02 11:05:34 PDT 
Committed r85493: <http://trac.webkit.org/changeset/85493>