Bug 59852 - WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins
Summary: WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-29 17:53 PDT by Alexey Proskuryakov
Modified: 2011-04-29 20:52 PDT (History)
4 users (show)

See Also:


Attachments
proposed fix (2.16 KB, patch)
2011-04-29 17:58 PDT, Alexey Proskuryakov
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-29 17:53:15 PDT
On some machines, this makes WebKit think that QuickTime supports Flash - it's present in the QT plug-ins plist, but is disabled.

<rdar://problem/9314011>
Comment 1 Alexey Proskuryakov 2011-04-29 17:58:03 PDT
Created attachment 91778 [details]
proposed fix
Comment 2 mitz 2011-04-29 18:02:24 PDT
Comment on attachment 91778 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=91778&action=review

> Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:150
> +        const void *isEnabled = CFDictionaryGetValue(mimeTypeInfo, CFSTR("WebPluginTypeEnabled"));

Star goes next to void, but this should be CFTypeRef, not void*.
Comment 3 Alexey Proskuryakov 2011-04-29 18:09:13 PDT
> Star goes next to void, but this should be CFTypeRef, not void*.

Why does CFDictionaryGetValue return const void *, and not CFTypeRef?
Comment 4 Alexey Proskuryakov 2011-04-29 18:11:42 PDT
On a second thought, I agree.
Comment 5 Alexey Proskuryakov 2011-04-29 20:52:37 PDT
Committed <http://trac.webkit.org/changeset/85386>