WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59846
Scrolling causes rounded bottom window corners to become square
https://bugs.webkit.org/show_bug.cgi?id=59846
Summary
Scrolling causes rounded bottom window corners to become square
Beth Dakin
Reported
2011-04-29 16:42:55 PDT
In a window with rounded corners, scrolling in WK2 causes the rounded corners to become square. <
rdar://problem/9234239
> Patch forthcoming.
Attachments
Patch
(3.29 KB, patch)
2011-04-29 16:51 PDT
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
Patch that addresses Simon's comments
(5.13 KB, patch)
2011-04-29 17:48 PDT
,
Beth Dakin
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2011-04-29 16:51:50 PDT
Created
attachment 91767
[details]
Patch
Simon Fraser (smfr)
Comment 2
2011-04-29 16:58:14 PDT
Comment on
attachment 91767
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=91767&action=review
> Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:145 > + NSDisableScreenUpdates();
A comment explaining why disabling is required would be good
> Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:161 > + m_windowBottomCornerIntersectionRect = NSZeroRect; > + m_windowBottomCornerIntersectionRect = [[m_wkView window] _intersectBottomCornersWithRect:[m_wkView convertRect:[m_wkView visibleRect] toView:nil]];
Why the double assignment?
Simon Fraser (smfr)
Comment 3
2011-04-29 17:07:59 PDT
Comment on
attachment 91767
[details]
Patch Maybe move this code to WKView, too?
Beth Dakin
Comment 4
2011-04-29 17:48:10 PDT
Created
attachment 91774
[details]
Patch that addresses Simon's comments
Simon Fraser (smfr)
Comment 5
2011-04-29 17:53:30 PDT
Comment on
attachment 91774
[details]
Patch that addresses Simon's comments View in context:
https://bugs.webkit.org/attachment.cgi?id=91774&action=review
> Source/WebKit2/UIProcess/API/mac/PageClientImpl.h:127 > + NSRect m_windowBottomCornerIntersectionRect;
This is unused?
> Source/WebKit2/UIProcess/API/mac/WKView.mm:933 > + BOOL maskWindow = window && !NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect);
Would read better if this was shouldMaskWindow
Beth Dakin
Comment 6
2011-04-29 17:56:55 PDT
(In reply to
comment #5
)
> (From update of
attachment 91774
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=91774&action=review
> > > Source/WebKit2/UIProcess/API/mac/PageClientImpl.h:127 > > + NSRect m_windowBottomCornerIntersectionRect; > > This is unused? >
Oops! Meant to remove that.
> > Source/WebKit2/UIProcess/API/mac/WKView.mm:933 > > + BOOL maskWindow = window && !NSIsEmptyRect(_data->_windowBottomCornerIntersectionRect); > > Would read better if this was shouldMaskWindow
Will change. Thanks!
Beth Dakin
Comment 7
2011-04-29 18:01:30 PDT
Committed fix with revision 85376.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug