Bug 59828 - HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
Summary: HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 14:06 PDT by Eric Carlson
Modified: 2011-05-02 10:53 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.25 KB, patch)
2011-04-30 15:40 PDT, Eric Carlson
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-04-29 14:06:23 PDT
At some point in the past, the spec required a seek to time 0 once metadata is loaded. The spec text has been changed to say:

   If either the media resource or the address of the current 
   media resource indicate a particular start time, then set 
   the initial playback position to that time, seek to that time, 
   and let jumped be true. Ignore any resulting exceptions 
   (if the position is out of range, it is effectively ignored).

WebKit doesn't support starting at an offset, so we should not force a seek to time 0.
Comment 1 Eric Carlson 2011-04-30 15:40:25 PDT
Created attachment 91807 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2011-05-01 09:48:58 PDT
So this is not at all visible from javascript (that surprises me).
Comment 3 Eric Carlson 2011-05-01 15:56:44 PDT
(In reply to comment #2)
> So this is not at all visible from javascript (that surprises me).

It isn't visible because it is a noop - the media file has just been opened and it is no playing, so "seeking" to time zero does nothing.
Comment 4 Eric Seidel (no email) 2011-05-01 16:30:12 PDT
Comment on attachment 91807 [details]
Proposed patch

OK.  Would be nice to say that in the ChagneLog. :)
Comment 5 Eric Carlson 2011-05-02 10:53:52 PDT
http://trac.webkit.org/changeset/85488 (with improved ChangeLog text ;-) )