Bug 59811 - Extract a function to obtain VisiblePosition from RenderText::positionForPoint
Summary: Extract a function to obtain VisiblePosition from RenderText::positionForPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 59435
  Show dependency tree / graph
 
Reported: 2011-04-29 11:09 PDT by Ryosuke Niwa
Modified: 2011-04-29 18:13 PDT (History)
7 users (show)

See Also:

Attachments
cleanup (4.40 KB, patch)
2011-04-29 12:11 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-04-29 11:09:57 PDT 
The part of RenderText::positionForPoint that returns visible positions when various conditions are met can be split into a separate function.
Comment 1 Ryosuke Niwa 2011-04-29 12:11:14 PDT 
Created attachment 91716 [details]
cleanup
Comment 2 Eric Seidel (no email) 2011-04-29 17:31:02 PDT 
Comment on attachment 91716 [details]
cleanup

LGTM.
Comment 3 Ryosuke Niwa 2011-04-29 17:32:34 PDT 
Thanks for the review, Eric.
Comment 4 WebKit Commit Bot 2011-04-29 18:12:28 PDT 
The commit-queue encountered the following flaky tests while processing attachment 91716 [details]:

http/tests/workers/shared-worker-importScripts.html bug 58634 (author: atwilson@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-04-29 18:13:39 PDT 
Comment on attachment 91716 [details]
cleanup

Clearing flags on attachment: 91716

Committed r85377: <http://trac.webkit.org/changeset/85377>
Comment 6 WebKit Commit Bot 2011-04-29 18:13:45 PDT 
All reviewed patches have been landed.  Closing bug.