Bug 59798 - Implement FULLSCREEN_API on Windows, Part 4: Enable it
Summary: Implement FULLSCREEN_API on Windows, Part 4: Enable it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 59785 59845
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-29 09:09 PDT by Jer Noble
Modified: 2011-05-03 23:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.51 KB, patch)
2011-04-29 10:15 PDT, Jer Noble
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-04-29 09:09:56 PDT
Implement FULLSCREEN_API on Windows, Part 4: Enable it
Comment 1 Jer Noble 2011-04-29 10:15:40 PDT
Created attachment 91694 [details]
Patch
Comment 2 Build Bot 2011-04-29 14:23:25 PDT
Attachment 91694 [details] did not build on win:
Build output: http://queues.webkit.org/results/8525190
Comment 3 Adam Roben (:aroben) 2011-04-29 18:48:06 PDT
(In reply to comment #2)
> Attachment 91694 [details] did not build on win:
> Build output: http://queues.webkit.org/results/8525190

Uh-oh!
Comment 4 Jer Noble 2011-04-29 18:58:13 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Attachment 91694 [details] [details] did not build on win:
> > Build output: http://queues.webkit.org/results/8525190
> 
> Uh-oh!

We may have to kick the builders when this patch goes in, if the scripts don't regenerate the UserAgentStyleSheetsData.cpp file.
Comment 5 Jer Noble 2011-04-29 19:01:21 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Attachment 91694 [details] [details] [details] did not build on win:
> > > Build output: http://queues.webkit.org/results/8525190
> > 
> > Uh-oh!
> 
> We may have to kick the builders when this patch goes in, if the scripts don't regenerate the UserAgentStyleSheetsData.cpp file.

I'll make a inconsequential change to the fullscreen.css file; that should "encourage" the DerivedSources.make file that it needs to rebuild UserAgentStyleSheetsData.cpp.
Comment 6 Eric Seidel (no email) 2011-05-01 09:51:14 PDT
Comment on attachment 91694 [details]
Patch

Ok.  I assume this is dependent on earlier patches.
Comment 7 Jer Noble 2011-05-01 13:28:03 PDT
(In reply to comment #6)
> (From update of attachment 91694 [details])
> Ok.  I assume this is dependent on earlier patches.

It sure is. :)   Thanks!
Comment 8 Jer Noble 2011-05-03 23:25:52 PDT
Committed r85719: <http://trac.webkit.org/changeset/85719>