Bug 59788 - Web Inspector: add "open link in new tab" action into the network and resources panels.
Summary: Web Inspector: add "open link in new tab" action into the network and resourc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-29 02:14 PDT by Pavel Feldman
Modified: 2011-04-29 02:35 PDT (History)
10 users (show)

See Also:


Attachments
Patch (23.87 KB, patch)
2011-04-29 02:25 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-29 02:14:05 PDT
This change also distinguishes context menu items case between platforms.
Comment 1 Pavel Feldman 2011-04-29 02:25:50 PDT
Created attachment 91655 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-29 02:33:43 PDT
Comment on attachment 91655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91655&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1018
> +                contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Save entry as HAR" : "Save Entry as HAR"), this._exportResource.bind(this, resource));

Can you encapsulate WebInspector.useLowerCaseMenuTitles() logic in UIString to avoid recurring ternary ifs ?
Comment 3 Pavel Feldman 2011-04-29 02:35:15 PDT
Committed r85312: <http://trac.webkit.org/changeset/85312>