WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
59783
sheriffbot gets angry when the build master is restarted
https://bugs.webkit.org/show_bug.cgi?id=59783
Summary
sheriffbot gets angry when the build master is restarted
Adam Roben (:aroben)
Reported
2011-04-29 00:00:33 PDT
When the build master is restarted, sheriffbot starts thinking that builds/tests have failed. It needs to chill out!
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-04-29 00:00:47 PDT
This has happened multiple times today, including just now.
Adam Barth
Comment 2
2011-04-29 00:07:36 PDT
:(
Eric Seidel (no email)
Comment 3
2011-04-29 00:34:00 PDT
sheriff-bot knows to ignore lost builders. but I guess he needs to be taught what restarts look like.
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py#L313
What do they look like? This is the file which decides what are failures to complain about, btw:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/failuremap.py
which is used by:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py
the actual communication with irc/bugzilla is done here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py
Adam Roben (:aroben)
Comment 4
2011-04-29 00:35:47 PDT
(In reply to
comment #3
)
> What do they look like?
Every build gets interrupted at once. They all go "purple" due to an exception being thrown.
Adam Roben (:aroben)
Comment 5
2011-04-29 00:37:13 PDT
I guess maybe they don't always go purple. Anyway, here's a few such interrupted builds:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/34171
http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/13238
http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/21106
Eric Seidel (no email)
Comment 6
2011-04-29 10:46:10 PDT
"lost" in that text should be enough to make buildbot.py treat them as green. If they were failing before, it's possible it would then report "new" failures when they come back, and go from "green" to red.
Eric Seidel (no email)
Comment 7
2012-12-23 16:35:34 PST
SB no longer watches builders, so this is probably obsolete now.
Eric Seidel (no email)
Comment 8
2012-12-23 16:38:54 PST
***
Bug 37099
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug