Bug 59776 - Sometimes WebKit2 pauses during launch due to waiting for the first render
Summary: Sometimes WebKit2 pauses during launch due to waiting for the first render
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 22:07 PDT by Stephanie Lewis
Modified: 2011-06-18 12:28 PDT (History)
3 users (show)

See Also:


Attachments
first patch (3.96 KB, patch)
2011-04-28 22:17 PDT, Stephanie Lewis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2011-04-28 22:07:15 PDT
Since the WebProcess is just going to send us a blank page until they have rendered the first time we shouldn't pause and wait for their update.  Instead we should continue to paint a blank window until the WebProcess has sent us the new bits.
Comment 1 Stephanie Lewis 2011-04-28 22:17:18 PDT
Created attachment 91635 [details]
first patch
Comment 2 WebKit Review Bot 2011-04-28 22:19:01 PDT
Attachment 91635 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:80:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2011-04-29 09:34:19 PDT
Comment on attachment 91635 [details]
first patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91635&action=review

>> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:80
>> +        if(!m_hasReceivedFirstUpdate)
> 
> Missing space before ( in if(  [whitespace/parens] [5]

I agree with the style bot.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:188
> +    else if (!m_hasReceivedFirstUpdate)
> +        m_hasReceivedFirstUpdate = true;

No need for the if statement here. You don’t have to check a boolean is false before setting it to true.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:102
> +    // For the first draw, don't draw anything until the WebProcess has sent over the bits.

This comment says “for the first draw”, but the code affects more than just the first draw, right?
Comment 4 Stephanie Lewis 2011-04-29 14:38:10 PDT

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:102
> +    // For the first draw, don't draw anything until the WebProcess has sent over the bits.

This comment says “for the first draw”, but the code affects more than just the first draw, right?

I should have said the first substantial draw or the first draw with content.
Comment 5 Darin Adler 2011-06-18 12:28:52 PDT
http://trac.webkit.org/changeset/85359