Bug 59772 - [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
Summary: [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-28 19:47 PDT by Keith Kyzivat
Modified: 2011-04-29 16:38 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.11 KB, patch)
2011-04-28 19:49 PDT, Keith Kyzivat
no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2011-04-29 13:06 PDT, Keith Kyzivat
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Kyzivat 2011-04-28 19:47:14 PDT
TestNetscapePlugin depends on Netscape Plugin support -- so if it is disabled via ENABLE_NETSCAPE_PLUGIN_API=0, we should not try to build this tool.
Comment 1 Keith Kyzivat 2011-04-28 19:49:06 PDT
Created attachment 91622 [details]
Patch
Comment 2 Csaba Osztrogonác 2011-04-29 04:49:12 PDT
Comment on attachment 91622 [details]
Patch

r- now, because DEFINES is emtpy here.

Please add an "include(../Source/WebCore/features.pri)" line 
after CONFIG to make checking ENABLE_NETSCAPE_PLUGIN_API work.
Comment 3 Keith Kyzivat 2011-04-29 05:43:35 PDT
(In reply to comment #2)
> (From update of attachment 91622 [details])
> r- now, because DEFINES is emtpy here.
> 
> Please add an "include(../Source/WebCore/features.pri)" line 
> after CONFIG to make checking ENABLE_NETSCAPE_PLUGIN_API work.

Oh duh! This worked for me during testing because I had ENABLE_NETSCAPE_PLUGIN_API defined on the command line.
Comment 4 Keith Kyzivat 2011-04-29 13:06:03 PDT
Created attachment 91721 [details]
Patch
Comment 5 Csaba Osztrogonác 2011-04-29 13:15:58 PDT
Comment on attachment 91721 [details]
Patch

Thanks, r=me
Comment 6 WebKit Commit Bot 2011-04-29 16:38:32 PDT
Comment on attachment 91721 [details]
Patch

Clearing flags on attachment: 91721

Committed r85370: <http://trac.webkit.org/changeset/85370>
Comment 7 WebKit Commit Bot 2011-04-29 16:38:37 PDT
All reviewed patches have been landed.  Closing bug.