Bug 59765 - [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
Summary: [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Martin Robinson
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-04-28 17:44 PDT by Martin Robinson
Modified: 2011-05-13 09:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (45.94 KB, patch)
2011-04-28 17:48 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-04-28 17:44:32 PDT 
Currently the GTK+ keybinding code is duplicated in both WebKit1 and WebKit2. By pushing it into a WebCore utility class we may share the code and also make the EditorClientGtk class smaller.
Comment 1 Martin Robinson 2011-04-28 17:48:56 PDT 
Created attachment 91609 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-04-29 00:11:54 PDT 
(In reply to comment #1)
> Created an attachment (id=91609) [details]
> Patch

Looks good to me.
Comment 3 Eric Seidel (no email) 2011-05-11 20:37:45 PDT 
Comment on attachment 91609 [details]
Patch

OK.  rs=me.
Comment 4 Martin Robinson 2011-05-13 09:00:40 PDT 
Comment on attachment 91609 [details]
Patch

Clearing flags on attachment: 91609

Committed r86436: <http://trac.webkit.org/changeset/86436>
Comment 5 Martin Robinson 2011-05-13 09:00:44 PDT 
All reviewed patches have been landed.  Closing bug.