Bug 59763 - DFG JIT - Unify FPRReg & FPRegisterID
Summary: DFG JIT - Unify FPRReg & FPRegisterID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 17:06 PDT by Gavin Barraclough
Modified: 2011-04-28 18:50 PDT (History)
1 user (show)

See Also:


Attachments
The patch (48.85 KB, patch)
2011-04-28 17:07 PDT, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Tweaked Patch! (54.02 KB, patch)
2011-04-28 17:15 PDT, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Ooops! reverted Node changes! (53.16 KB, patch)
2011-04-28 17:16 PDT, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Double ooops! - revert platform change! (52.61 KB, patch)
2011-04-28 17:18 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-04-28 17:06:25 PDT
(Following on from GPRReg/RegisterID unification).
Comment 1 Gavin Barraclough 2011-04-28 17:07:54 PDT
Created attachment 91595 [details]
The patch
Comment 2 WebKit Review Bot 2011-04-28 17:09:30 PDT
Attachment 91595 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGFPRInfo.h:60:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/dfg/DFGFPRInfo.h:91:  fpr_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-04-28 17:15:45 PDT
Created attachment 91599 [details]
Tweaked Patch!
Comment 4 Gavin Barraclough 2011-04-28 17:16:58 PDT
Created attachment 91600 [details]
Ooops! reverted Node changes!
Comment 5 WebKit Review Bot 2011-04-28 17:17:08 PDT
Attachment 91599 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGFPRInfo.h:60:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/dfg/DFGFPRInfo.h:91:  fpr_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Gavin Barraclough 2011-04-28 17:18:15 PDT
Created attachment 91601 [details]
Double ooops! - revert platform change!
Comment 7 WebKit Review Bot 2011-04-28 17:19:46 PDT
Attachment 91600 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGFPRInfo.h:60:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/dfg/DFGFPRInfo.h:91:  fpr_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Review Bot 2011-04-28 17:20:32 PDT
Attachment 91601 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGFPRInfo.h:60:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/dfg/DFGFPRInfo.h:91:  fpr_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Gavin Barraclough 2011-04-28 18:50:35 PDT
ixed in r85271