Bug 59760 - Right-clicking on a Flash movie in an iframe shows the browser context menu
Summary: Right-clicking on a Flash movie in an iframe shows the browser context menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 16:32 PDT by Anders Carlsson
Modified: 2011-04-28 16:44 PDT (History)
0 users

See Also:

Attachments
Patch (2.60 KB, patch)
2011-04-28 16:37 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-04-28 16:32:33 PDT 
Right-clicking on a Flash movie in an iframe shows the browser context menu
Comment 1 Anders Carlsson 2011-04-28 16:37:23 PDT 
Created attachment 91587 [details]
Patch
Comment 2 Darin Adler 2011-04-28 16:40:02 PDT 
Comment on attachment 91587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91587&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:956
> +                return handleContextMenuEvent(platformMouseEvent, page);

Is it really OK to ignore the result of “handled” entirely here? Not || it in? Is it correct to return false if the mouse press event was handled, but not the context menu event?
Comment 3 Anders Carlsson 2011-04-28 16:41:39 PDT 
Comment on attachment 91587 [details]
Patch

I think so; the semantics are still the same as they were before my change.
Comment 4 Anders Carlsson 2011-04-28 16:44:32 PDT 
Committed r85259: <http://trac.webkit.org/changeset/85259>