WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59760
Right-clicking on a Flash movie in an iframe shows the browser context menu
https://bugs.webkit.org/show_bug.cgi?id=59760
Summary
Right-clicking on a Flash movie in an iframe shows the browser context menu
Anders Carlsson
Reported
2011-04-28 16:32:33 PDT
Right-clicking on a Flash movie in an iframe shows the browser context menu
Attachments
Patch
(2.60 KB, patch)
2011-04-28 16:37 PDT
,
Anders Carlsson
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-04-28 16:37:23 PDT
Created
attachment 91587
[details]
Patch
Darin Adler
Comment 2
2011-04-28 16:40:02 PDT
Comment on
attachment 91587
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=91587&action=review
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:956 > + return handleContextMenuEvent(platformMouseEvent, page);
Is it really OK to ignore the result of “handled” entirely here? Not || it in? Is it correct to return false if the mouse press event was handled, but not the context menu event?
Anders Carlsson
Comment 3
2011-04-28 16:41:39 PDT
Comment on
attachment 91587
[details]
Patch I think so; the semantics are still the same as they were before my change.
Anders Carlsson
Comment 4
2011-04-28 16:44:32 PDT
Committed
r85259
: <
http://trac.webkit.org/changeset/85259
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug