Bug 59757 - REGRESSION(r85101): it'd be better to rollout the patch and do another one with another property name. Current one will bring us to a problem at first run after upgrade because it's type was changed from int to string. (Requested by loislo on #webkit).
Summary: REGRESSION(r85101): it'd be better to rollout the patch and do another one w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 59630
  Show dependency treegraph
 
Reported: 2011-04-28 16:18 PDT by WebKit Review Bot
Modified: 2011-04-28 17:06 PDT (History)
2 users (show)

See Also:


Attachments
ROLLOUT of r85101 (2.38 KB, patch)
2011-04-28 16:18 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-04-28 16:18:04 PDT
http://trac.webkit.org/changeset/85101 broke the build:
 it'd be better to rollout the patch and do another one with another property name. Current one will bring us to a problem at first run after upgrade because it's type was changed from int to string. (Requested by loislo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-04-28 16:18:25 PDT
Created attachment 91583 [details]
ROLLOUT of r85101

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ilya Tikhonovsky 2011-04-28 17:06:32 PDT
Comment on attachment 91583 [details]
ROLLOUT of r85101

Clearing flags on attachment: 91583

Committed r85266: <http://trac.webkit.org/changeset/85266>
Comment 3 Ilya Tikhonovsky 2011-04-28 17:06:35 PDT
All reviewed patches have been landed.  Closing bug.