Bug 59756 – Chromium Mac: Enable overlay scrollbars

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sailesh Agrawal]

This bug is to track the work to enable overlay scrollbars.

[Sailesh Agrawal]

Created attachment 91581 [details]
Patch

[WebKit Review Bot]

Attachment 91581 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sailesh Agrawal]

Created attachment 91729 [details]
Fixed some bugs

[WebKit Review Bot]

Attachment 91729 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sailesh Agrawal]

Created attachment 91736 [details]
Updated change log.

[Sailesh Agrawal]

Created attachment 91739 [details]
Fixed style errors

[Sam Weinig]

Comment on attachment 91739 [details]
Fixed style errors

This again contains copied code.  Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding.

[Sailesh Agrawal]

Created attachment 94692 [details]
Patch

[Sailesh Agrawal]

(In reply to comment #7)
> (From update of attachment 91739 [details])
> This again contains copied code.  Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding.

I've updated the ChangeLog to describe what's added and changed.

I talked to Beth Dakin about the code duplication issue. We agreed that it would be ok to live with the code duplication until smooth scrolling is enabled on the Mac (hopefully very soon). I've filed bug 61144 to track this issue.

[Sailesh Agrawal]

Created attachment 96452 [details]
Patch

[Sailesh Agrawal]

Try bot passed:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/31160

[Mihai Parparita]

Comment on attachment 96452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Enable  WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.

One too many spaces after "Enable"

[Sailesh Agrawal]

Created attachment 96485 [details]
Patch

[Sailesh Agrawal]

Comment on attachment 96452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        Enable  WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.
> 
> One too many spaces after "Enable"

Fixed.

[WebKit Review Bot]

Comment on attachment 96485 [details]
Patch

Clearing flags on attachment: 96485

Committed r88396: <http://trac.webkit.org/changeset/88396>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.