Bug 59756 - Chromium Mac: Enable overlay scrollbars
Summary: Chromium Mac: Enable overlay scrollbars
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 61401
Blocks: 59728
  Show dependency tree / graph
 
Reported: 2011-04-28 16:11 PDT by Sailesh Agrawal
Modified: 2011-06-08 15:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.46 KB, patch)
2011-04-28 16:16 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Fixed some bugs (19.19 KB, patch)
2011-04-29 14:02 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Updated change log. (19.54 KB, patch)
2011-04-29 14:14 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Fixed style errors (19.54 KB, patch)
2011-04-29 14:18 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (16.33 KB, patch)
2011-05-24 14:46 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (30.83 KB, patch)
2011-06-08 12:10 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Patch (30.83 KB, patch)
2011-06-08 14:46 PDT, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-04-28 16:11:32 PDT 
This bug is to track the work to enable overlay scrollbars.
Comment 1 Sailesh Agrawal 2011-04-28 16:16:38 PDT 
Created attachment 91581 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-28 16:52:53 PDT 
Attachment 91581 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sailesh Agrawal 2011-04-29 14:02:18 PDT 
Created attachment 91729 [details]
Fixed some bugs
Comment 4 WebKit Review Bot 2011-04-29 14:04:38 PDT 
Attachment 91729 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sailesh Agrawal 2011-04-29 14:14:33 PDT 
Created attachment 91736 [details]
Updated change log.
Comment 6 Sailesh Agrawal 2011-04-29 14:18:28 PDT 
Created attachment 91739 [details]
Fixed style errors
Comment 7 Sam Weinig 2011-05-01 13:30:37 PDT 
Comment on attachment 91739 [details]
Fixed style errors

This again contains copied code.  Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding.
Comment 8 Sailesh Agrawal 2011-05-24 14:46:53 PDT 
Created attachment 94692 [details]
Patch
Comment 9 Sailesh Agrawal 2011-05-24 14:49:09 PDT 
(In reply to comment #7)
> (From update of attachment 91739 [details])
> This again contains copied code.  Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding.

I've updated the ChangeLog to describe what's added and changed.

I talked to Beth Dakin about the code duplication issue. We agreed that it would be ok to live with the code duplication until smooth scrolling is enabled on the Mac (hopefully very soon). I've filed bug 61144 to track this issue.
Comment 10 Sailesh Agrawal 2011-06-08 12:10:37 PDT 
Created attachment 96452 [details]
Patch
Comment 11 Sailesh Agrawal 2011-06-08 14:24:20 PDT 
Try bot passed:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/31160
Comment 12 Mihai Parparita 2011-06-08 14:40:32 PDT 
Comment on attachment 96452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Enable  WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.

One too many spaces after "Enable"
Comment 13 Sailesh Agrawal 2011-06-08 14:46:20 PDT 
Created attachment 96485 [details]
Patch
Comment 14 Sailesh Agrawal 2011-06-08 14:46:46 PDT 
Comment on attachment 96452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        Enable  WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.
> 
> One too many spaces after "Enable"

Fixed.
Comment 15 WebKit Review Bot 2011-06-08 15:24:49 PDT 
Comment on attachment 96485 [details]
Patch

Clearing flags on attachment: 96485

Committed r88396: <http://trac.webkit.org/changeset/88396>
Comment 16 WebKit Review Bot 2011-06-08 15:24:55 PDT 
All reviewed patches have been landed.  Closing bug.