Bug 59750 – fast/harness/results.html failing in some configurations

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kenneth Russell]

fast/harness/results.html is failing in some configurations, at least Chromium Win. Please see:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/2315

Adding a downstream suppression for the moment.

[Ojan Vafai]

Created attachment 91575 [details]
Patch

[Darin Adler]

Comment on attachment 91575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review

> LayoutTests/fast/harness/resources/results-test.js:318
> +        // Use a regexp to match windows and unix-style paths.

Never heard of windows and unix, maybe you mean Windows and Unix? ;-)

> LayoutTests/fast/harness/resources/results-test.js:319
> +        var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html');

Does this need a ^ and a $, or does the exec function only match the entire URL?

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 91575 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review
> 
> > LayoutTests/fast/harness/resources/results-test.js:318
> > +        // Use a regexp to match windows and unix-style paths.
> 
> Never heard of windows and unix, maybe you mean Windows and Unix? ;-)

lol. Will fix.

> > LayoutTests/fast/harness/resources/results-test.js:319
> > +        var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html');
> 
> Does this need a ^ and a $, or does the exec function only match the entire URL?

Oh good point. It does need them.

[Ojan Vafai]

Committed r85260: <http://trac.webkit.org/changeset/85260>