Bug 59750 - fast/harness/results.html failing in some configurations
Summary: fast/harness/results.html failing in some configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on: 59711
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-28 15:36 PDT by Kenneth Russell
Modified: 2011-04-28 16:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.63 KB, patch)
2011-04-28 15:58 PDT, Ojan Vafai
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-04-28 15:36:42 PDT
fast/harness/results.html is failing in some configurations, at least Chromium Win. Please see:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/2315

Adding a downstream suppression for the moment.
Comment 1 Ojan Vafai 2011-04-28 15:58:39 PDT
Created attachment 91575 [details]
Patch
Comment 2 Darin Adler 2011-04-28 16:38:24 PDT
Comment on attachment 91575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review

> LayoutTests/fast/harness/resources/results-test.js:318
> +        // Use a regexp to match windows and unix-style paths.

Never heard of windows and unix, maybe you mean Windows and Unix? ;-)

> LayoutTests/fast/harness/resources/results-test.js:319
> +        var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html');

Does this need a ^ and a $, or does the exec function only match the entire URL?
Comment 3 Ojan Vafai 2011-04-28 16:43:12 PDT
(In reply to comment #2)
> (From update of attachment 91575 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review
> 
> > LayoutTests/fast/harness/resources/results-test.js:318
> > +        // Use a regexp to match windows and unix-style paths.
> 
> Never heard of windows and unix, maybe you mean Windows and Unix? ;-)

lol. Will fix.

> > LayoutTests/fast/harness/resources/results-test.js:319
> > +        var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html');
> 
> Does this need a ^ and a $, or does the exec function only match the entire URL?

Oh good point. It does need them.
Comment 4 Ojan Vafai 2011-04-28 16:47:02 PDT
Committed r85260: <http://trac.webkit.org/changeset/85260>