Bug 59746 - WebKit2: Frequent crashes in acceptsFirstMouse
Summary: WebKit2: Frequent crashes in acceptsFirstMouse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-28 15:17 PDT by Alexey Proskuryakov
Modified: 2011-04-28 16:02 PDT (History)
0 users

See Also:


Attachments
proposed fix (9.52 KB, patch)
2011-04-28 15:27 PDT, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-04-28 15:17:33 PDT
We are making sync calls without checking that connection is valid.
Comment 1 Alexey Proskuryakov 2011-04-28 15:22:53 PDT
<rdar://problem/9281270>
Comment 2 Alexey Proskuryakov 2011-04-28 15:27:05 PDT
Created attachment 91569 [details]
proposed fix
Comment 3 Anders Carlsson 2011-04-28 15:53:41 PDT
Comment on attachment 91569 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=91569&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:186
> +        location = 0;
> +        length = 0;
> +        return;

Shouldn't location be NSNotFound here?

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:194
> +        location = 0;

Ditto
Comment 4 Alexey Proskuryakov 2011-04-28 16:02:15 PDT
Maybe, not sure. Changed to NSNotFound.

Committed <http://trac.webkit.org/changeset/85252>.