RESOLVED WONTFIX 59745
Sharing strings across threads now always require copies the 1st time.
https://bugs.webkit.org/show_bug.cgi?id=59745
Summary Sharing strings across threads now always require copies the 1st time.
David Levin
Reported 2011-04-28 15:16:12 PDT
Strings are suppose to move across thread without copies but this got broken when the StringImpl internal buffer support got added. Gavin has some good ideas about how to fix this: 1. If I understand correctly, we would change StringImpl::deref so that it didn't do delete a StringImpl was shared and make it so that in the BufferShared case it pointed to the buffer part of a StringImpl which is BufferInternal. 2. Alternatively we could always allocate a separate buffer for large strings. The first approach is only slightly more complicated but seems more efficient.
Attachments
David Levin
Comment 1 2012-01-05 16:38:55 PST
The shared string stuff was removed. When it was removed, I looked at the cases that were the motivating cases and they had over time been changed to no longer need the sharing, so this bug is obsolete.
Note You need to log in before you can comment on or make changes to this bug.