This breaks automated tests of mac production builds
Created attachment 91564 [details] patch
Attachment 91564 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/m..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 91564 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=91564&action=review Marking as r- as the destination path is not correct. > Tools/ChangeLog:6 > + Add an install target for production builds. You can put this on a single line. > Tools/ChangeLog:8 > + * DumpRenderTree/mac/PerlSupport/Makefile: You’re missing a blank line after this. > Tools/DumpRenderTree/mac/PerlSupport/Makefile:78 > +INSTALL_PATH=/System/Library/Frameworks I don’t like the name INSTALL_PATH for this since INSTALL_PATH in Xcode configuration settings means something different. It wouldn’t hurt to use SYSTEM_LIBRARY_DIR in place of the hard-coded /System/Library here either. And if you’re going to pull the base of the destination directory out in to an environment variable, I’d suggest pulling all of it rather than just a subset from the middle. > Tools/DumpRenderTree/mac/PerlSupport/Makefile:82 > + cp $(PERL_MODULE) $(NEXT_ROOT)/$(INSTALL_PATH)/$(WEBKIT_FRAMEWORK_RESOURCES_PATH)/DumpRenderTreeSupport.pm This isn’t right. Files need to be installed below DSTROOT.
Created attachment 91642 [details] new install location
committed http://trac.webkit.org/projects/webkit/changeset/85308