Bug 59743 - DumpRenderTree should have an install target for the Perl support module
Summary: DumpRenderTree should have an install target for the Perl support module
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.6
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-04-28 15:06 PDT by Stephanie Lewis
Modified: 2011-06-18 19:15 PDT (History)
4 users (show)

See Also:

patch (1.23 KB, patch)
2011-04-28 15:07 PDT, Stephanie Lewis
mrowe: review-
Details | Formatted Diff | Diff
new install location (1.28 KB, patch)
2011-04-28 22:58 PDT, Stephanie Lewis
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2011-04-28 15:06:26 PDT
This breaks automated tests of mac production builds
Comment 1 Stephanie Lewis 2011-04-28 15:07:24 PDT
Created attachment 91564 [details]
Comment 2 WebKit Review Bot 2011-04-28 15:08:58 PDT
Attachment 91564 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/m..." exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2011-04-28 15:25:06 PDT
Comment on attachment 91564 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=91564&action=review

Marking as r- as the destination path is not correct.

> Tools/ChangeLog:6
> +        Add an install target for production builds.

You can put this on a single line.

> Tools/ChangeLog:8
> +        * DumpRenderTree/mac/PerlSupport/Makefile:

You’re missing a blank line after this.

> Tools/DumpRenderTree/mac/PerlSupport/Makefile:78
> +INSTALL_PATH=/System/Library/Frameworks

I don’t like the name INSTALL_PATH for this since INSTALL_PATH in Xcode configuration settings means something different.  It wouldn’t hurt to use SYSTEM_LIBRARY_DIR in place of the hard-coded /System/Library here either.  And if you’re going to pull the base of the destination directory out in to an environment variable, I’d suggest pulling all of it rather than just a subset from the middle.

> Tools/DumpRenderTree/mac/PerlSupport/Makefile:82

This isn’t right.  Files need to be installed below DSTROOT.
Comment 4 Stephanie Lewis 2011-04-28 22:58:12 PDT
Created attachment 91642 [details]
new install location
Comment 5 Stephanie Lewis 2011-06-18 19:15:52 PDT
committed http://trac.webkit.org/projects/webkit/changeset/85308