Chromium Mac: Add scrollbar overlay drawing functions
Created attachment 91560 [details] Patch
Created attachment 91562 [details] Patch
Comment on attachment 91562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91562&action=review I think this looks fine. I'm not a reviewer, though. > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:38 > +// we lookup at runtime. If the private APIs don't exist then the wkMake* s/lookup/look up/
Comment on attachment 91562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91562&action=review > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:36 > +// This file contains utilities to draw overlay scrollbars. There are no plublic s/plublic/public/. > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:106 > +static Class LookUpNSScrollerImpClass() { There's a quite a few WebKit style issues here: - opening brace should be on its own line for function definitions. - The first letter does not need to be capitalized. - Indents should be 4 spaces.
Created attachment 91585 [details] Addressed review comments
Comment on attachment 91562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91562&action=review >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:36 >> +// This file contains utilities to draw overlay scrollbars. There are no plublic > > s/plublic/public/. Fixed. >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:38 >> +// we lookup at runtime. If the private APIs don't exist then the wkMake* > > s/lookup/look up/ Fixed. >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:106 >> +static Class LookUpNSScrollerImpClass() { > > There's a quite a few WebKit style issues here: > - opening brace should be on its own line for function definitions. > - The first letter does not need to be capitalized. > - Indents should be 4 spaces. Fixed.
Mark the patch review? if you would like it reviewed. Also, when uploading a new patch you should obsolete any patches it replaces. webkit-patch upload will take care of this for you.
Created attachment 91727 [details] Fixed some bugs
Created attachment 91735 [details] Updated change log.
Comment on attachment 91735 [details] Updated change log. Clearing flags on attachment: 91735 Committed r85492: <http://trac.webkit.org/changeset/85492>
All reviewed patches have been landed. Closing bug.