Bug 59700 - [Skia] Fix shadow behavior for both CSS and Canvas
Summary: [Skia] Fix shadow behavior for both CSS and Canvas
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Mike Reed
Depends on:
Reported: 2011-04-28 08:04 PDT by Mike Reed
Modified: 2011-04-28 17:00 PDT (History)
9 users (show)

See Also:

Patch (10.36 KB, patch)
2011-04-28 08:08 PDT, Mike Reed
no flags Details | Formatted Diff | Diff
Patch (10.44 KB, patch)
2011-04-28 10:09 PDT, Mike Reed
no flags Details | Formatted Diff | Diff
Patch (10.45 KB, patch)
2011-04-28 11:47 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-04-28 08:04:34 PDT
fix shadw behavior for both CSS and Canvas
Comment 1 Mike Reed 2011-04-28 08:08:23 PDT
Created attachment 91491 [details]
Comment 2 WebKit Review Bot 2011-04-28 08:10:48 PDT
Attachment 91491 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:16:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:17:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:18:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 12 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mike Reed 2011-04-28 10:09:04 PDT
Created attachment 91509 [details]
Comment 4 Simon Fraser (smfr) 2011-04-28 10:39:14 PDT
Bug title should make it obvious that this is a Skia-only change.
Comment 5 Eric Seidel (no email) 2011-04-28 11:34:47 PDT
Looks fine to me.  I'm willing to rubber-stamp this.
Comment 6 Eric Seidel (no email) 2011-04-28 11:35:11 PDT
Comment on attachment 91509 [details]

Do we need updated test expectations?
Comment 7 Kenneth Russell 2011-04-28 11:37:13 PDT
Comment on attachment 91509 [details]

Looks fine to me assuming it's been tested. Do you want to update the bug synopsis and ChangeLog descriptions per Simon's feedback?
Comment 8 Mike Reed 2011-04-28 11:44:41 PDT
test expectations are updated, but only to remove expected failures. Basically this is fixing a previous break.
Comment 9 Mike Reed 2011-04-28 11:47:00 PDT
Created attachment 91531 [details]
Comment 10 Eric Seidel (no email) 2011-04-28 11:47:49 PDT
Comment on attachment 91531 [details]

Comment 11 Stephen White 2011-04-28 12:10:17 PDT
Comment on attachment 91531 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=91531&action=review

> Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:-457
> -    if (!alpha || windowsCanHandleDrawTextShadow(graphicsContext) || !windowsCanHandleTextDrawingWithoutShadow(graphicsContext)) {

Since you're removing the calls to these functions, I think the only remaining caller is windowsCanHandleTextDrawing().  For clarity, we could also revert that function to be like it was pre-r83541, and remove the *Shadow() and *WithoutShadow() flavours.  This could be done in a followup patch.

> LayoutTests/platform/chromium/test_expectations.txt:2528
> +BUGCR63921 GPU : fast/canvas/canvas-strokePath-alpha-shadow.html = TEXT TIMEOUT

Unless I'm missing something, these should remain GPU WIN LINUX.  We shouldn't be running the canvas tests on GPU MAC.
Comment 12 WebKit Commit Bot 2011-04-28 16:59:57 PDT
Comment on attachment 91531 [details]

Clearing flags on attachment: 91531

Committed r85264: <http://trac.webkit.org/changeset/85264>
Comment 13 WebKit Commit Bot 2011-04-28 17:00:03 PDT
All reviewed patches have been landed.  Closing bug.