Hi, when a css stylesheet has no content-type, and a random file extension (such as php), that css sheet is not loaded. This happens for example with http://open.mapquest.co.uk/ : site fails with webkit/gtk but fails with other browsers. In CachedCSSStyleSheet::canUseSheet, there is following comment: // Note that we grab the Content-Type // header directly because we want to see what the value is BEFORE content // sniffing. So, it looks like Content-Type header should match official Content-Type, but soup backend replaces it with the sniffed one. So may be, sniffed Content-Type should be kept in a separate variable, and not be injected into soup message headers.
Created attachment 91487 [details] Patch patch attempt
Created attachment 91489 [details] patch v1.1 prevents a memory leak
Comment on attachment 91489 [details] patch v1.1 View in context: https://bugs.webkit.org/attachment.cgi?id=91489&action=review Just a style nit. > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:345 > + soup_header_g_string_append_param(str, (const char*) key, (const char*) value); This should use C++-style casts like this: static_cast<const char*>(key).
Created attachment 91490 [details] patch v1.2 fixes style
Created attachment 91493 [details] patch v1.3 fixes style
Comment on attachment 91493 [details] patch v1.3 Great work, thanks!
The commit-queue encountered the following flaky tests while processing attachment 91493 [details]: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Comment on attachment 91493 [details] patch v1.3 Clearing flags on attachment: 91493 Committed r85207: <http://trac.webkit.org/changeset/85207>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/85207 might have broken SnowLeopard Intel Release (Tests)