Bug 59696 - Chromium DevTools: Fix network panel timing/size/headers tests.
Summary: Chromium DevTools: Fix network panel timing/size/headers tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 06:41 PDT by Vsevolod Vlasov
Modified: 2011-04-29 03:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.09 KB, patch)
2011-04-28 06:46 PDT, Vsevolod Vlasov
pfeldman: review-
Details | Formatted Diff | Diff
Patch with fixes (4.69 KB, patch)
2011-04-29 02:54 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-04-28 06:41:40 PDT
Fix network panel timing/size/headers tests.
Timing/size tests are flaky now, should be more stable.
Test expectations for headers text should be updated.
Comment 1 Vsevolod Vlasov 2011-04-28 06:46:57 PDT
Created attachment 91482 [details]
Patch
Comment 2 Pavel Feldman 2011-04-28 10:47:28 PDT
Comment on attachment 91482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91482&action=review

> Source/WebKit/chromium/src/js/Tests.js:533
> +        test.assertTrue(resource.transferSize === 219 || resource.transferSize === 221, 

219 or 221? :) why?

> Source/WebKit/chromium/src/js/Tests.js:534
> +                "Incorrect total encoded data length: should be 219 (or 221), but was resource.transferSize=" + resource.transferSize + ".");

weird indent.

> Source/WebKit/chromium/src/js/Tests.js:559
> +                "Incorrect total encoded data length: should be 219 (or 221), but was resource.transferSize=" + resource.transferSize + ".");

ditto
Comment 3 Vsevolod Vlasov 2011-04-29 02:54:54 PDT
Created attachment 91657 [details]
Patch with fixes
Comment 4 WebKit Commit Bot 2011-04-29 03:23:17 PDT
Comment on attachment 91657 [details]
Patch with fixes

Clearing flags on attachment: 91657

Committed r85314: <http://trac.webkit.org/changeset/85314>
Comment 5 WebKit Commit Bot 2011-04-29 03:23:21 PDT
All reviewed patches have been landed.  Closing bug.