RESOLVED FIXED 59679
[GTK] Create the page client in the view widget 
https://bugs.webkit.org/show_bug.cgi?id=59679
Summary [GTK] Create the page client in the view widget
Carlos Garcia Campos
Reported 2011-04-28 01:59:21 PDT
Instead of the opposite, it looks more natural to me and simplifies WKView code.
Attachments
Patch (11.17 KB, patch)
2011-04-28 02:07 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (13.13 KB, patch)
2011-04-28 03:12 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-04-28 02:07:49 PDT
Created attachment 91451 [details] Patch
Carlos Garcia Campos
Comment 2 2011-04-28 03:12:22 PDT
Created attachment 91455 [details] Updated patch I forgot to use new for the private struct, instead of GObject mechanism, so that page client and web page objecs are correctly released.
Martin Robinson
Comment 3 2011-04-28 08:47:17 PDT
Comment on attachment 91455 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=91455&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:379 > + priv->page->initializeWebPage(); Where is this method defined? > Source/WebKit2/UIProcess/gtk/WebView.h:50 > + WebPageProxy* page() const; Please call this one pageProxy, just to be clear.
Martin Robinson
Comment 4 2011-04-28 08:52:36 PDT
Comment on attachment 91455 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=91455&action=review >> Source/WebKit2/UIProcess/gtk/WebView.h:50 >> + WebPageProxy* page() const; > > Please call this one pageProxy, just to be clear. Carlos reminded me that we are about to remove this.
Carlos Garcia Campos
Comment 5 2011-04-28 09:39:41 PDT
Committed r85196: <http://trac.webkit.org/changeset/85196>
Note You need to log in before you can comment on or make changes to this bug.