Bug 59677 - Added dynamic tests for missing properties in TextElement
Summary: Added dynamic tests for missing properties in TextElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Felician Marton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 01:47 PDT by Felician Marton
Modified: 2011-05-25 03:34 PDT (History)
5 users (show)

See Also:


Attachments
Added dynamic tests for missing properties in TextElement (24.87 KB, patch)
2011-04-29 04:29 PDT, Felician Marton
zimmermann: review-
Details | Formatted Diff | Diff
Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added. (414.07 KB, patch)
2011-05-03 06:17 PDT, Felician Marton
zimmermann: review-
Details | Formatted Diff | Diff
Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. (414.09 KB, patch)
2011-05-05 06:57 PDT, Felician Marton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felician Marton 2011-04-28 01:47:29 PDT
Some new dynamic updates added
  * textElement x prop + attr
  * textElement y prop + attr
  * textElement dx prop + attr
  * textElement dy prop + attr
  * textElement rotate attr
Comment 1 Felician Marton 2011-04-29 04:29:19 PDT
Created attachment 91664 [details]
Added dynamic tests for missing properties in TextElement
Comment 2 Nikolas Zimmermann 2011-04-29 08:48:19 PDT
Comment on attachment 91664 [details]
Added dynamic tests for missing properties in TextElement

The tests look fine, nice work! Though the pixel test results are missing, you have to use run-webkit-tests -p --reset-results svg/dynamic-updates/yourtest.svg. Can you update the patch?
Comment 3 Felician Marton 2011-05-03 06:17:18 PDT
Created attachment 92065 [details]
 Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
Comment 4 Nikolas Zimmermann 2011-05-05 01:14:13 PDT
Comment on attachment 92065 [details]
 Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.

The text "Text content" is clipped a bit on top, can you fix that first?
Comment 5 Felician Marton 2011-05-05 06:57:03 PDT
Created attachment 92411 [details]
Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping.
Comment 6 Csaba Osztrogonác 2011-05-25 03:09:08 PDT
Comment on attachment 92411 [details]
Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. 

LGTM, r=me. (based on Niko's comments)
Comment 7 WebKit Commit Bot 2011-05-25 03:34:39 PDT
Comment on attachment 92411 [details]
Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. 

Clearing flags on attachment: 92411

Committed r87284: <http://trac.webkit.org/changeset/87284>
Comment 8 WebKit Commit Bot 2011-05-25 03:34:46 PDT
All reviewed patches have been landed.  Closing bug.