Some new dynamic updates added * textElement x prop + attr * textElement y prop + attr * textElement dx prop + attr * textElement dy prop + attr * textElement rotate attr
Created attachment 91664 [details] Added dynamic tests for missing properties in TextElement
Comment on attachment 91664 [details] Added dynamic tests for missing properties in TextElement The tests look fine, nice work! Though the pixel test results are missing, you have to use run-webkit-tests -p --reset-results svg/dynamic-updates/yourtest.svg. Can you update the patch?
Created attachment 92065 [details] Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
Comment on attachment 92065 [details] Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added. The text "Text content" is clipped a bit on top, can you fix that first?
Created attachment 92411 [details] Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping.
Comment on attachment 92411 [details] Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. LGTM, r=me. (based on Niko's comments)
Comment on attachment 92411 [details] Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. Clearing flags on attachment: 92411 Committed r87284: <http://trac.webkit.org/changeset/87284>
All reviewed patches have been landed. Closing bug.