RESOLVED FIXED 59677
Added dynamic tests for missing properties in TextElement 
https://bugs.webkit.org/show_bug.cgi?id=59677
Summary Added dynamic tests for missing properties in TextElement
Felician Marton
Reported 2011-04-28 01:47:29 PDT
Some new dynamic updates added * textElement x prop + attr * textElement y prop + attr * textElement dx prop + attr * textElement dy prop + attr * textElement rotate attr
Attachments
Added dynamic tests for missing properties in TextElement (24.87 KB, patch)
2011-04-29 04:29 PDT, Felician Marton 		zimmermann: review-
DetailsFormatted DiffDiff
Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added. (414.07 KB, patch)
2011-05-03 06:17 PDT, Felician Marton 		zimmermann: review-
DetailsFormatted DiffDiff
Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. (414.09 KB, patch)
2011-05-05 06:57 PDT, Felician Marton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Felician Marton
Comment 1 2011-04-29 04:29:19 PDT
Created attachment 91664 [details] Added dynamic tests for missing properties in TextElement
Nikolas Zimmermann
Comment 2 2011-04-29 08:48:19 PDT
Comment on attachment 91664 [details] Added dynamic tests for missing properties in TextElement The tests look fine, nice work! Though the pixel test results are missing, you have to use run-webkit-tests -p --reset-results svg/dynamic-updates/yourtest.svg. Can you update the patch?
Felician Marton
Comment 3 2011-05-03 06:17:18 PDT
Created attachment 92065 [details] Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
Nikolas Zimmermann
Comment 4 2011-05-05 01:14:13 PDT
Comment on attachment 92065 [details] Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added. The text "Text content" is clipped a bit on top, can you fix that first?
Felician Marton
Comment 5 2011-05-05 06:57:03 PDT
Created attachment 92411 [details] Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping.
Csaba Osztrogonác
Comment 6 2011-05-25 03:09:08 PDT
Comment on attachment 92411 [details] Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. LGTM, r=me. (based on Niko's comments)
WebKit Commit Bot
Comment 7 2011-05-25 03:34:39 PDT
Comment on attachment 92411 [details] Dynamic tests for missing properties in TextElement. The corresponding Mac pixel test results also added. Without clipping. Clearing flags on attachment: 92411 Committed r87284: <http://trac.webkit.org/changeset/87284>
WebKit Commit Bot
Comment 8 2011-05-25 03:34:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.