Bug 59674 - Add way to install testapi in production builds
Summary: Add way to install testapi in production builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 23:12 PDT by Sam Weinig
Modified: 2011-04-28 09:07 PDT (History)
1 user (show)

See Also:

Attachments
Patch (9.79 KB, patch)
2011-04-27 23:13 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2011-04-28 08:30 PDT, Sam Weinig 		ddkilzer: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-27 23:12:22 PDT 
Add way to install testapi in production builds
Comment 1 Sam Weinig 2011-04-27 23:13:37 PDT 
Created attachment 91432 [details]
Patch
Comment 2 Mark Rowe (bdash) 2011-04-27 23:19:21 PDT 
Comment on attachment 91432 [details]
Patch

Can you recreate this without the svn cp of JavaScriptCore.xcconfig to TestAPI.xcconfig?  The change itself looks good, but that gives bogus history.
Comment 3 Sam Weinig 2011-04-28 08:30:17 PDT 
Created attachment 91496 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2011-04-28 09:05:01 PDT 
Comment on attachment 91496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91496&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +        Remove in project build settings and add missing configuration files.

Nit: "in project" should be hyphenated as "in-project" since it's used as an adjective.

You should also note that you're adding CompilerVersion.xcconfig here since that is just an additional clean-up step.  (It should also be done for the other 4 projects that added it.)
Comment 5 Sam Weinig 2011-04-28 09:07:20 PDT 
Committed r85189: <http://trac.webkit.org/changeset/85189>