Bug 59668 – [chromium] Compute compositor fps value and history using the frameBegin timestamp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nat Duca]

[chromium] Compute compositor fps value and history using the frameBegin timestamp

[Nat Duca]

Created attachment 91420 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 91420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91420&action=review

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:58
> +using namespace WTF;

Generally wtf headers do this for you...

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:16
> + * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AYN

Nope.

[Nat Duca]

Created attachment 91508 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 91508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91508&action=review

R=me, but please fix nits before committing.

> Source/WebCore/ChangeLog:9
> +        beginning of the frame rather than the time we call swapBuffers. When scheudling is

oops: scheudling

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:196
> +    // This value is currently inaccessible because it is up in RenderWidget.

I think you mean Chromium's RenderWidget (render_widget.cc), but this could be
confused with WebCore::RenderWidget.

[Nat Duca]

Created attachment 91541 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 91541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91541&action=review

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:196
> +    // This value is currently inaccessible because it is up in Chromiuum's

Chromiuum -> Chromium

[Nat Duca]

Created attachment 91551 [details]
chromiuuuuuuuuuuuuuuuuum ftw

[WebKit Commit Bot]

Comment on attachment 91551 [details]
chromiuuuuuuuuuuuuuuuuum ftw

Clearing flags on attachment: 91551

Committed r85261: <http://trac.webkit.org/changeset/85261>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/85261 might have broken WinCE Release (Build)