Bug 59664 - Fix OwnPtr strict issues in chromium linux build
Summary: Fix OwnPtr strict issues in chromium linux build
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
Depends on:
Blocks: 59666
  Show dependency treegraph
Reported: 2011-04-27 18:22 PDT by James Robinson
Modified: 2011-04-27 18:42 PDT (History)
3 users (show)

See Also:

Patch (5.62 KB, patch)
2011-04-27 18:22 PDT, James Robinson
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-04-27 18:22:13 PDT
Fix OwnPtr strict issues in chromium linux build
Comment 1 James Robinson 2011-04-27 18:22:42 PDT
Created attachment 91395 [details]
Comment 2 Adam Barth 2011-04-27 18:27:37 PDT
Comment on attachment 91395 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=91395&action=review

> Source/WebKit/chromium/src/WebImageDecoder.cpp:115
> -    OwnPtr<NativeImageSkia>image(frameBuffer->asNewNativeImage());
> +    OwnPtr<NativeImageSkia> image(adoptPtr(frameBuffer->asNewNativeImage()));

We usually prefer the = form of the constructor.
Comment 3 James Robinson 2011-04-27 18:42:31 PDT
Committed r85135: <http://trac.webkit.org/changeset/85135>