Bug 59646 - Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
Summary: Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 16:00 PDT by Geoffrey Garen
Modified: 2011-04-27 17:19 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2011-04-27 16:05 PDT, Geoffrey Garen 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-04-27 16:00:16 PDT 
Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
Comment 1 Geoffrey Garen 2011-04-27 16:05:41 PDT 
Created attachment 91368 [details]
Patch
Comment 2 Sam Weinig 2011-04-27 16:14:11 PDT 
Comment on attachment 91368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91368&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:-221
> -    HashMap<CSSValue*, void*>& cssValueRoots();

Can we remove the forward declaration of CSSValue here now?
Comment 3 Geoffrey Garen 2011-04-27 16:25:18 PDT 
> Can we remove the forward declaration of CSSValue here now?

As you wish!
Comment 4 Geoffrey Garen 2011-04-27 17:19:54 PDT 
Committed r85127: <http://trac.webkit.org/changeset/85127>