Bug 59645 - Add ability to remove keys from weakmap API
Summary: Add ability to remove keys from weakmap API
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
Depends on:
Reported: 2011-04-27 15:58 PDT by Oliver Hunt
Modified: 2011-04-27 16:54 PDT (History)
3 users (show)

See Also:

Patch (2.97 KB, patch)
2011-04-27 15:59 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-27 15:58:53 PDT
Add ability to remove keys from weakmap API
Comment 1 Oliver Hunt 2011-04-27 15:59:53 PDT
Created attachment 91366 [details]
Comment 2 Geoffrey Garen 2011-04-27 16:01:55 PDT
Comment on attachment 91366 [details]

Comment 3 WebKit Review Bot 2011-04-27 16:03:05 PDT
Attachment 91366 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSWeakObjectMapR..." exit_code: 1

Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h:86:  The parameter name "map" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Oliver Hunt 2011-04-27 16:07:25 PDT
Committed r85117: <http://trac.webkit.org/changeset/85117>
Comment 5 WebKit Review Bot 2011-04-27 16:54:18 PDT
http://trac.webkit.org/changeset/85117 might have broken Qt Linux Release