Bug 59634 - Port Mozilla's IndexedDB tests: event.target.result after add() and put()
Summary: Port Mozilla's IndexedDB tests: event.target.result after add() and put()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 14:19 PDT by Mark Pilgrim (Google)
Modified: 2011-04-28 11:49 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.65 KB, patch)
2011-04-27 14:21 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-04-27 14:19:19 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_key_requirements.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It checks the value of event.target.result after the asynchronous add() and put() methods. WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-04-27 14:21:17 PDT
Created attachment 91348 [details]
Patch
Comment 2 David Grogan 2011-04-27 15:46:35 PDT
Comment on attachment 91348 [details]
Patch

r+

Mark, I'll let you set /cq?/
Comment 3 WebKit Commit Bot 2011-04-27 21:37:42 PDT
Comment on attachment 91348 [details]
Patch

Clearing flags on attachment: 91348

Committed r85148: <http://trac.webkit.org/changeset/85148>
Comment 4 WebKit Commit Bot 2011-04-27 21:37:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Tony Chang 2011-04-28 11:46:11 PDT
(In reply to comment #4)
> All reviewed patches have been landed.  Closing bug.

This test is failing on the bots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fmozilla%2Fkey-requirements.html&group=%40ToT%20-%20chromium.org

Looks like the expected result is incorrect (the description is wrong).  I'll land a fix.
Comment 6 Tony Chang 2011-04-28 11:48:38 PDT
Fixed expected result in http://trac.webkit.org/changeset/85217.
Comment 7 Mark Pilgrim (Google) 2011-04-28 11:49:17 PDT
Sorry about that. Thanks, Tony.