Bug 59633 - Work around currently-spurious ASSERT in WTF's random number generator for Chromium workers
Summary: Work around currently-spurious ASSERT in WTF's random number generator for Ch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 14:18 PDT by Adam Klein
Modified: 2011-04-27 14:46 PDT (History)
3 users (show)

See Also:


Attachments
Patch (659 bytes, patch)
2011-04-27 14:24 PDT, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-04-27 14:18:45 PDT
The short story is that we want to remove these ASSERT's in Chromium's M12 branch.  But the end goal is to fix this, for real, in a patch on 55728 by enabling WTF_MULTIPLE_THREADs.

See https://bugs.webkit.org/show_bug.cgi?id=55728 and http://code.google.com/p/chromium/issues/detail?id=80713 for details.
Comment 1 Adam Klein 2011-04-27 14:24:04 PDT
Created attachment 91349 [details]
Patch
Comment 2 Adam Klein 2011-04-27 14:25:09 PDT
Attached the patch I intend to apply to branches/chromium/742.
Comment 3 Adam Barth 2011-04-27 14:25:43 PDT
Comment on attachment 91349 [details]
Patch

Why are these threads spurious?  We need to define JSC_MULTIPLE_THREADS if we using more than one thread.  There's a bug about renaming it to WTF_MULTIPLE_THREADS
Comment 4 Adam Barth 2011-04-27 14:26:13 PDT
> Why are these threads spurious?

^^^ ASSERTS :)
Comment 5 Adam Barth 2011-04-27 14:26:48 PDT
Ah, I fail to read.
Comment 6 Adam Barth 2011-04-27 14:37:37 PDT
Comment on attachment 91349 [details]
Patch

r=me for the branch.
Comment 7 Adam Klein 2011-04-27 14:46:10 PDT
Committed as http://trac.webkit.org/changeset/85098

Closing bug.