WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59631
Port Mozilla's IndexedDB tests: creating unique index and updating indexNames
https://bugs.webkit.org/show_bug.cgi?id=59631
Summary
Port Mozilla's IndexedDB tests: creating unique index and updating indexNames
Mark Pilgrim (Google)
Reported
2011-04-27 13:55:16 PDT
Original test:
http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_create_index.html?force=1
This is a port of a test from Mozilla's IndexedDB test suite. It checks the basics of creating a unique index and seeing that indexNames is updated afterwards. WebKit passes this test.
Attachments
Patch
(5.34 KB, patch)
2011-04-27 13:56 PDT
,
Mark Pilgrim (Google)
no flags
Details
Formatted Diff
Diff
Patch
(5.35 KB, patch)
2011-04-27 14:37 PDT
,
Mark Pilgrim (Google)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1
2011-04-27 13:56:53 PDT
Created
attachment 91340
[details]
Patch
David Grogan
Comment 2
2011-04-27 14:22:31 PDT
Comment on
attachment 91340
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=91340&action=review
Good stuff.
> LayoutTests/storage/indexeddb/mozilla/create-index-unique.html:49 > +function cleanDatabase()
Same comment as yesterday - change to a less misleading name. This does more than cleaning the database.
Mark Pilgrim (Google)
Comment 3
2011-04-27 14:37:42 PDT
Created
attachment 91351
[details]
Patch
Mark Pilgrim (Google)
Comment 4
2011-04-27 14:38:24 PDT
Fixed function name. No other changes.
David Grogan
Comment 5
2011-04-27 14:39:40 PDT
Comment on
attachment 91351
[details]
Patch r+
WebKit Commit Bot
Comment 6
2011-04-27 22:20:05 PDT
Comment on
attachment 91351
[details]
Patch Clearing flags on attachment: 91351 Committed
r85154
: <
http://trac.webkit.org/changeset/85154
>
WebKit Commit Bot
Comment 7
2011-04-27 22:20:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug