Bug 59625 - address aesthetic concerns for results.html format brought up at webkit meeting
Summary: address aesthetic concerns for results.html format brought up at webkit meeting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 12:20 PDT by Ojan Vafai
Modified: 2011-04-27 14:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2011-04-27 12:22 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
screenshot (22.82 KB, image/png)
2011-04-27 12:23 PDT, Ojan Vafai 		no flags Details
another screenshot (24.60 KB, image/png)
2011-04-27 12:25 PDT, Ojan Vafai 		no flags Details
Patch (4.04 KB, patch)
2011-04-27 12:26 PDT, Ojan Vafai 		eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-04-27 12:20:31 PDT 
address aesthetic concerns for results.html format brought up at webkit meeting
Comment 1 Ojan Vafai 2011-04-27 12:22:01 PDT 
Created attachment 91320 [details]
Patch
Comment 2 Ojan Vafai 2011-04-27 12:23:34 PDT 
Created attachment 91321 [details]
screenshot

It's much closer aesthetically to the old format now. The places where it differs are all functional.
Comment 3 Ojan Vafai 2011-04-27 12:25:01 PDT 
Created attachment 91322 [details]
another screenshot
Comment 4 Ojan Vafai 2011-04-27 12:26:38 PDT 
Created attachment 91323 [details]
Patch
Comment 5 Eric Seidel (no email) 2011-04-27 13:51:52 PDT 
Comment on attachment 91323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91323&action=review

OK.

> LayoutTests/fast/harness/results.html:417
> +TableSorter._backwardArrow = '<svg style="width:10px;height:10px"><polygon points="0,10 10,10 5,0" style="fill:#ccc"></svg>';

omg. svg.
Comment 6 Ojan Vafai 2011-04-27 14:11:31 PDT 
Committed r85089: <http://trac.webkit.org/changeset/85089>