Bug 59614 – WK2 Mac client certificate authentication

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

WebKit2 on Mac needs the ability to authenticate with client certificates.

In radar as <rdar://problem/8773946>

[Brady Eidson]

Created attachment 91296 [details]
Patch v1

[WebKit Review Bot]

Attachment 91296 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/API/C/mac/WKCredentialMac.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 91301 [details]
Patch v2 - Update alphabetization

[Jeff Miller]

Comment on attachment 91301 [details]
Patch v2 - Update alphabetization

View in context: https://bugs.webkit.org/attachment.cgi?id=91301&action=review

> Source/WebKit2/UIProcess/Authentication/WebCredential.cpp:49
> +

I know it's a pain, but these member functions should really be put into a new mac/WebCredentialMac.cpp file (or mac/WebCredentialMac.mm, I'm not sure what our convention is here).

[Brady Eidson]

(In reply to comment #4)
> (From update of attachment 91301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91301&action=review
> 
> > Source/WebKit2/UIProcess/Authentication/WebCredential.cpp:49
> > +
> 
> I know it's a pain, but these member functions should really be put into a new mac/WebCredentialMac.cpp file (or mac/WebCredentialMac.mm, I'm not sure what our convention is here).

I think what you were trying to say was mac/WebCredential.mac.mm  ;)

[Brady Eidson]

And, not that much of a pain because it's just one project file change.

[Brady Eidson]

Created attachment 91504 [details]
Patch v3 - With WebCredential.mac.mm split off

[Brady Eidson]

Created attachment 91524 [details]
Patch v4 - Removed all the cross platform ifdefness, even if Mac is the only user right now.

[Brady Eidson]

Landed in r85223